Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot Proactive Message TeamsFx - Azure Provision Fixes #1487

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

Mohammed-MSFT
Copy link
Contributor

No description provided.

@Mohammed-MSFT
Copy link
Contributor Author

@Wajeed-msft Wajeed-msft requested a review from Copilot December 18, 2024 05:06

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 6 changed files in this pull request and generated no comments.

Files not reviewed (4)
  • samples/bot-proactive-messaging-teamsfx/.vscode/tasks.json: Language not supported
  • samples/bot-proactive-messaging-teamsfx/aad.manifest.json: Language not supported
  • samples/bot-proactive-messaging-teamsfx/appPackage/manifest.json: Language not supported
  • samples/bot-proactive-messaging-teamsfx/env/.env.dev: Language not supported
Comments suppressed due to low confidence (2)

samples/bot-proactive-messaging-teamsfx/teamsapp.local.yml:29

  • The environment variable name 'PROVISIONOUTPUT__BOTOUTPUT__SITEENDPOINT' uses double underscores, which might be a typo. Verify if this is intended or should be 'PROVISIONOUTPUT_BOTOUTPUT_SITEENDPOINT'.
messagingEndpoint: ${{PROVISIONOUTPUT__BOTOUTPUT__SITEENDPOINT}}/api/messages

samples/bot-proactive-messaging-teamsfx/teamsapp.local.yml:62

  • The environment variable name 'PROVISIONOUTPUT__BOTOUTPUT__SITEENDPOINT' uses double underscores, which might be a typo. Verify if this is intended or should be 'PROVISIONOUTPUT_BOTOUTPUT_SITEENDPOINT'.
INITIATE_LOGIN_ENDPOINT: ${{PROVISIONOUTPUT__BOTOUTPUT__SITEENDPOINT}}/auth-start.html
Copy link
Collaborator

@Pawank-MSFT Pawank-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks correct, approving!

Copy link
Contributor

@Harikrishnan-MSFT Harikrishnan-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Mohammed-MSFT Mohammed-MSFT merged commit 5e5ba3a into main Dec 19, 2024
271 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants